add llm support for wasip2 sdk #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
changed the title
rajatjindal
commented
Apr 3, 2025
adamreese
approved these changes
Apr 9, 2025
Contributor
adamreese
left a comment
adamreese
left a comment
There was a problem hiding this comment.
LGTM. A few thoughts that don't need to block this PR...
Some of the types have changed and we should think about if documentation is needed somewhere. For example MaxTokens is changed from int32 to uint32.
Type aliases make godocs difficult to read. Should we consider duplicating the types rather than using aliases?
Signed-off-by: Rajat Jindal <[email protected]>
rajatjindal
force-pushed
the
spin-w2-llm
branch
from
88c159a to
8c008a4
Compare
Member
Author
|
Hi @adamreese, this is ready for another round of review now. thanks for your help. |
adamreese
approved these changes
Apr 11, 2025
Contributor
adamreese
left a comment
adamreese
left a comment
There was a problem hiding this comment.
Amazing work as always Rajat
Member
Author
❤️ 🙏 thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in draft as I need to verify a few more scenarios before its ready for review.this is ready for review now. we can't add integration test for it as it needs a GPU to run efficiently.